From: Krishna Kumar <krkumar2@in•ibm.com>
To: davem@davemloft•net, rdreier@cisco•com
Cc: johnpol@2ka•mipt.ru, Robert.Olsson@data•slu.se,
peter.p.waskiewicz.jr@intel•com, herbert@gondor•apana.org.au,
gaagaan@gmail•com, kumarkr@linux•ibm.com, xma@us•ibm.com,
rick.jones2@hp•com, mcarlson@broadcom•com, jagana@us•ibm.com,
mchan@broadcom•com, general@lists•openfabrics.org,
netdev@vger•kernel.org, tgraf@suug•ch, jeff@garzik•org,
hadi@cyberus•ca, kaber@trash•net,
Krishna Kumar <krkumar2@in•ibm.com>,
sri@us•ibm.com
Subject: [PATCH 04/10] net-sysfs.c changes.
Date: Fri, 20 Jul 2007 12:02:38 +0530 [thread overview]
Message-ID: <20070720063238.26341.41474.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070720063149.26341.84076.sendpatchset@localhost.localdomain>
Support to turn on/off batching from /sys.
Signed-off-by: Krishna Kumar <krkumar2@in•ibm.com>
---
net-sysfs.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 70 insertions(+)
diff -ruNp org/net/core/net-sysfs.c new/net/core/net-sysfs.c
--- org/net/core/net-sysfs.c 2007-07-20 07:49:28.000000000 +0530
+++ new/net/core/net-sysfs.c 2007-07-20 08:34:45.000000000 +0530
@@ -230,6 +230,74 @@ static ssize_t store_weight(struct devic
return netdev_store(dev, attr, buf, len, change_weight);
}
+static ssize_t show_tx_batch_skbs(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct net_device *netdev = to_net_dev(dev);
+
+ return sprintf(buf, fmt_dec, netdev->skb_blist ? 1 : 0);
+}
+
+static int change_tx_batch_skbs(struct net_device *net,
+ unsigned long new_tx_batch_skbs)
+{
+ int ret = 0;
+ struct sk_buff_head *blist;
+
+ if (!(net->features & NETIF_F_BATCH_SKBS) ||
+ (new_tx_batch_skbs && net->tx_queue_len < MIN_QUEUE_LEN_BATCH)) {
+ /*
+ * Driver doesn't support batching SKBS, or the queue len
+ * is insufficient. TODO: Add similar check to disable
+ * batching in change_tx_queue_len() if queue_len becomes
+ * smaller than MIN_QUEUE_LEN_BATCH.
+ */
+ ret = -ENOTSUPP;
+ goto out;
+ }
+
+ /* Handle invalid argument */
+ if (new_tx_batch_skbs < 0) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ /* Check if new value is same as the current */
+ new_tx_batch_skbs = !!new_tx_batch_skbs;
+ if (!!net->skb_blist == new_tx_batch_skbs)
+ goto out;
+
+ if (new_tx_batch_skbs &&
+ (blist = kmalloc(sizeof *blist, GFP_KERNEL)) == NULL) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ spin_lock(&net->queue_lock);
+ if (new_tx_batch_skbs) {
+ skb_queue_head_init(blist);
+ net->skb_blist = blist;
+ net->tx_queue_len >>= 1;
+ } else {
+ if (!skb_queue_empty(net->skb_blist))
+ skb_queue_purge(net->skb_blist);
+ kfree(net->skb_blist);
+ net->skb_blist = NULL;
+ net->tx_queue_len <<= 1;
+ }
+ spin_unlock(&net->queue_lock);
+
+out:
+ return ret;
+}
+
+static ssize_t store_tx_batch_skbs(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ return netdev_store(dev, attr, buf, len, change_tx_batch_skbs);
+}
+
static struct device_attribute net_class_attributes[] = {
__ATTR(addr_len, S_IRUGO, show_addr_len, NULL),
__ATTR(iflink, S_IRUGO, show_iflink, NULL),
@@ -246,6 +314,8 @@ static struct device_attribute net_class
__ATTR(flags, S_IRUGO | S_IWUSR, show_flags, store_flags),
__ATTR(tx_queue_len, S_IRUGO | S_IWUSR, show_tx_queue_len,
store_tx_queue_len),
+ __ATTR(tx_batch_skbs, S_IRUGO | S_IWUSR, show_tx_batch_skbs,
+ store_tx_batch_skbs),
__ATTR(weight, S_IRUGO | S_IWUSR, show_weight, store_weight),
{}
};
next prev parent reply other threads:[~2007-07-20 6:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 6:31 [ofa-general] [PATCH 00/10] Implement batching skb API Krishna Kumar
2007-07-20 6:32 ` [ofa-general] [PATCH 01/10] HOWTO documentation for Batching SKB Krishna Kumar
2007-07-20 6:32 ` [PATCH 02/10] Networking include file changes Krishna Kumar
2007-07-20 9:59 ` Patrick McHardy
2007-07-20 17:25 ` [ofa-general] " Sridhar Samudrala
2007-07-21 6:30 ` Krishna Kumar2
2007-07-23 5:59 ` Sridhar Samudrala
2007-07-23 6:27 ` Krishna Kumar2
2007-07-20 6:32 ` [ofa-general] [PATCH 03/10] dev.c changes Krishna Kumar
2007-07-20 10:04 ` [ofa-general] " Patrick McHardy
2007-07-20 10:27 ` Krishna Kumar2
2007-07-20 11:20 ` [ofa-general] " Patrick McHardy
2007-07-20 11:52 ` Krishna Kumar2
2007-07-20 11:55 ` Patrick McHardy
2007-07-20 12:09 ` Krishna Kumar2
2007-07-20 12:25 ` Krishna Kumar2
2007-07-20 12:37 ` Patrick McHardy
2007-07-20 17:44 ` Sridhar Samudrala
2007-07-21 6:44 ` Krishna Kumar2
2007-07-20 6:32 ` Krishna Kumar [this message]
2007-07-20 10:07 ` [ofa-general] Re: [PATCH 04/10] net-sysfs.c changes Patrick McHardy
2007-07-20 10:28 ` Krishna Kumar2
2007-07-20 11:21 ` Patrick McHardy
2007-07-20 16:22 ` Stephen Hemminger
2007-07-21 6:46 ` Krishna Kumar2
2007-07-23 9:56 ` Stephen Hemminger
2007-07-20 6:32 ` [ofa-general] [PATCH 05/10] sch_generic.c changes Krishna Kumar
2007-07-20 10:11 ` [ofa-general] " Patrick McHardy
2007-07-20 10:32 ` Krishna Kumar2
2007-07-20 11:24 ` Patrick McHardy
2007-07-20 18:16 ` Patrick McHardy
2007-07-21 6:56 ` Krishna Kumar2
2007-07-22 17:03 ` Patrick McHardy
2007-07-20 6:33 ` [ofa-general] [PATCH 06/10] IPoIB header file changes Krishna Kumar
2007-07-20 6:33 ` [ofa-general] [PATCH 07/10] IPoIB verb changes Krishna Kumar
2007-07-20 6:33 ` [ofa-general] [PATCH 08/10] IPoIB multicast/CM changes Krishna Kumar
2007-07-20 6:33 ` [PATCH 09/10] IPoIB batching xmit handler support Krishna Kumar
2007-07-20 6:33 ` [PATCH 10/10] IPoIB batching in internal xmit/handler routines Krishna Kumar
2007-07-20 7:18 ` [ofa-general] Re: [PATCH 00/10] Implement batching skb API Stephen Hemminger
2007-07-20 7:30 ` Krishna Kumar2
2007-07-20 7:57 ` [ofa-general] " Stephen Hemminger
2007-07-20 7:47 ` Krishna Kumar2
2007-07-21 13:46 ` [ofa-general] TCP and batching WAS(Re: " jamal
2007-07-23 9:44 ` Stephen Hemminger
2007-07-20 12:54 ` [ofa-general] " Evgeniy Polyakov
2007-07-20 13:02 ` Krishna Kumar2
2007-07-23 4:23 ` Krishna Kumar2
2007-07-21 13:18 ` [ofa-general] " jamal
2007-07-22 6:27 ` Krishna Kumar2
2007-07-22 12:51 ` jamal
2007-07-23 4:49 ` Krishna Kumar2
2007-07-23 12:32 ` jamal
2007-07-24 3:44 ` [ofa-general] " Krishna Kumar2
2007-07-24 19:28 ` jamal
2007-07-25 2:41 ` Krishna Kumar2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720063238.26341.41474.sendpatchset@localhost.localdomain \
--to=krkumar2@in$(echo .)ibm.com \
--cc=Robert.Olsson@data$(echo .)slu.se \
--cc=davem@davemloft$(echo .)net \
--cc=gaagaan@gmail$(echo .)com \
--cc=general@lists$(echo .)openfabrics.org \
--cc=hadi@cyberus$(echo .)ca \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jagana@us$(echo .)ibm.com \
--cc=jeff@garzik$(echo .)org \
--cc=johnpol@2ka$(echo .)mipt.ru \
--cc=kaber@trash$(echo .)net \
--cc=kumarkr@linux$(echo .)ibm.com \
--cc=mcarlson@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
--cc=rdreier@cisco$(echo .)com \
--cc=rick.jones2@hp$(echo .)com \
--cc=sri@us$(echo .)ibm.com \
--cc=tgraf@suug$(echo .)ch \
--cc=xma@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox