From: Michael Buesch <mb@bu3sch•de>
To: Andi Kleen <andi@firstfloor•org>
Cc: Jeff Garzik <jeff@garzik•org>,
ggrundstrom@neteffect•com, rdreier@cisco•com,
ewg@lists•openfabrics.org, netdev@vger•kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines
Date: Wed, 8 Aug 2007 15:55:03 +0200 [thread overview]
Message-ID: <200708081555.03588.mb@bu3sch.de> (raw)
In-Reply-To: <200708081548.25399.mb@bu3sch.de>
On Wednesday 08 August 2007 15:48:25 Michael Buesch wrote:
> > However if that's true then there are quite some drivers wrong:
> >
> > % grep -r write[bwl]\(cpu_to * | wc -l
> > 57
>
> Yeah, seems so.
Most of them seem to be
__raw_writew(cpu_toXX(...
which I think might be valid.
But there are indeed a few cases that look wrong.
arch/mips/pci/ops-bonito64.c: writel(cpu_to_le32(*data), addrp);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target);
arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target);
drivers/atm/fore200e.c: writel(cpu_to_le32(val), addr);
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), setup_frm); setup_frm += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), setup_frm); setup_frm += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), setup_frm); setup_frm += 8;
drivers/net/starfire.c: writew(cpu_to_be16(i), filter_addr);
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 8;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 8;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4;
drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 8;
drivers/net/hamachi.c: writel(cpu_to_le64(hmp->rx_ring_dma), ioaddr + RxPtr);
drivers/net/hamachi.c: writel(cpu_to_le64(hmp->rx_ring_dma) >> 32, ioaddr + RxPtr + 4);
drivers/net/hamachi.c: writel(cpu_to_le64(hmp->tx_ring_dma), ioaddr + TxPtr);
drivers/net/hamachi.c: writel(cpu_to_le64(hmp->tx_ring_dma) >> 32, ioaddr + TxPtr + 4);
drivers/net/hamachi.c: writel(cpu_to_le32(hmp->rx_ring_dma), ioaddr + RxPtr);
drivers/net/hamachi.c: writel(cpu_to_le32(hmp->tx_ring_dma), ioaddr + TxPtr);
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, rx_ring, 512, PCI_DMA_FROMDEVICE)),
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, &streamer_priv->streamer_rx_ring[0],
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, &streamer_priv->streamer_rx_ring[STREAMER_RX_RING_SIZE - 1],
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev,
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev,
drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev,
drivers/net/via-velocity.c: writel(cpu_to_le32(vptr->rd_pool_dma), ®s->RDBaseLo);
drivers/net/via-velocity.c: writel(cpu_to_le32(vptr->td_pool_dma[i]), &(regs->TDBaseLo[i]));
drivers/scsi/nsp32_io.h: writew(cpu_to_le16(val), ptr);
drivers/scsi/nsp32_io.h: writel(cpu_to_le32(val), ptr);
drivers/scsi/nsp32_io.h: writew(cpu_to_le16(val), data_ptr );
drivers/block/umem.c: writel(cpu_to_le32((page->page_dma+offset)&0xffffffff),
drivers/block/umem.c: writel(cpu_to_le32(((u64)page->page_dma)>>32),
drivers/block/umem.c: writel(cpu_to_le32(DMASCR_GO | DMASCR_CHAIN_EN | pci_cmds),
drivers/block/umem.c: writel(cpu_to_le32(DMASCR_DMA_COMPLETE|DMASCR_CHAIN_COMPLETE),
--
Greetings Michael.
next prev parent reply other threads:[~2007-08-08 13:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 0:45 [PATCH 2/14] nes: device structures and defines ggrundstrom
2007-08-08 1:13 ` Jeff Garzik
2007-08-08 12:38 ` Andi Kleen
2007-08-08 11:50 ` Michael Buesch
2007-08-08 12:55 ` Andi Kleen
2007-08-08 13:02 ` Michael Buesch
2007-08-08 13:08 ` Andi Kleen
2007-08-08 13:28 ` Michael Buesch
2007-08-08 13:38 ` Andi Kleen
2007-08-08 13:48 ` Michael Buesch
2007-08-08 13:55 ` Michael Buesch [this message]
2007-08-08 16:18 ` Roland Dreier
2007-08-08 16:25 ` Jeff Garzik
2007-08-08 16:30 ` Michael Buesch
2007-08-08 16:33 ` Jeff Garzik
2007-08-08 16:43 ` Michael Buesch
2007-08-08 16:46 ` Roland Dreier
2007-08-08 16:57 ` akepner
2007-08-08 16:59 ` Jeff Garzik
2007-08-08 17:34 ` Michael Buesch
2007-08-08 19:40 ` Jeff Garzik
2007-08-08 16:39 ` Roland Dreier
2007-08-08 16:19 ` Jeff Garzik
2007-08-08 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708081555.03588.mb@bu3sch.de \
--to=mb@bu3sch$(echo .)de \
--cc=andi@firstfloor$(echo .)org \
--cc=ewg@lists$(echo .)openfabrics.org \
--cc=ggrundstrom@neteffect$(echo .)com \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdreier@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox