Subject: Re: [PATCH] SSB PCI core driver fixes

From: Michael Buesch <[email-masked]>
Date: Thu, 9 Aug 2007 02:27:06 +0200

On Thursday 09 August 2007, Aurelien Jarno wrote:
>  - Add some delay between the configuration of the PCI controller 
>    and its registration.

Why? It is _huge_ and people won't like it ;)
At least add a comment why this is needed.

> @@ -340,6 +345,7 @@
>  	 * The following needs change, if we want to port hostmode
>  	 * to non-MIPS platform. */
>  	set_io_port_base((unsigned long)ioremap_nocache(SSB_PCI_MEM, 0x04000000));
> +	mdelay(300);
>  	register_pci_controller(&ssb_pcicore_controller);
>  }
>