Subject: Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

From: Benjamin LaHaise <[email-masked]>
Date: Fri, 10 Aug 2007 17:13:49 -0400

On Fri, Aug 10, 2007 at 02:05:13PM -0700, [email-masked] wrote:
> Also added a "disable_autoneg" module argument to completely disable
> autoneg on all cards using this driver.
...
> [akpm: this is a previously-nacked patch, but the problem is real]

Please remove this part of the patch.  The ethtool support is sufficient and 
doesn't clobber other cards in the system.  At the very least the module 
parameter has to be limited to a specific card.

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <[email-masked]>.