From: Domen Puncer <domen.puncer@telargo•com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols•net>,
linuxppc-embedded@ozlabs•org, netdev@vger•kernel.org
Subject: Re: [RFC PATCH v0.1] net driver: mpc52xx fec
Date: Mon, 13 Aug 2007 09:21:31 +0200 [thread overview]
Message-ID: <20070813072131.GD13994@moe.telargo.com> (raw)
In-Reply-To: <20070810130225.GE3375@ghostprotocols.net>
On 10/08/07 10:02 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 10, 2007 at 11:51:53AM +0200, Domen Puncer escreveu:
> > +static u8 null_mac[6];
>
> const
OK.
...
> > +static void fec_set_paddr(struct net_device *dev, u8 *mac)
> > +{
> > + struct fec_priv *priv = netdev_priv(dev);
> > + struct mpc52xx_fec __iomem *fec = priv->fec;
> > +
> > + out_be32(&fec->paddr1, *(u32*)(&mac[0]));
> > + out_be32(&fec->paddr2, (*(u16*)(&mac[4]) << 16) | FEC_PADDR2_TYPE);
>
> spaces after the types on casts to pointers
I assume you mean: out_be32(&fec->paddr1, *(u32 *)(&mac[0]));
>
> > +}
> > +
> > +static void fec_get_paddr(struct net_device *dev, u8 *mac)
> > +{
> > + struct fec_priv *priv = netdev_priv(dev);
> > + struct mpc52xx_fec __iomem *fec = priv->fec;
> > +
> > + *(u32*)(&mac[0]) = in_be32(&fec->paddr1);
> > + *(u16*)(&mac[4]) = in_be32(&fec->paddr2) >> 16;
>
> ditto
OK.
>
> > +}
> > +
> > +static int fec_set_mac_address(struct net_device *dev, void *addr)
> > +{
> > + struct sockaddr *sock = (struct sockaddr *)addr;
>
> no need for a cast, addr is a void pointer
Right, missed this one.
>
> > +
> > + memcpy(dev->dev_addr, sock->sa_data, dev->addr_len);
> > +
> > + fec_set_paddr(dev, sock->sa_data);
> > + return 0;
>
> Why always return 0? make it void
Because struct net_device->set_mac_address's prototype is like that.
>
> > +}
> > +
> > +static void fec_free_rx_buffers(struct bcom_task *s)
> > +{
> > + struct sk_buff *skb;
> > +
> > + while (!bcom_queue_empty(s)) {
> > + skb = bcom_retrieve_buffer(s, NULL, NULL);
> > + kfree_skb(skb);
> > + }
> > +}
> > +
> > +static int fec_alloc_rx_buffers(struct bcom_task *rxtsk)
> > +{
> > + while (!bcom_queue_full(rxtsk)) {
> > + struct sk_buff *skb;
> > + struct bcom_fec_bd *bd;
> > +
> > + skb = dev_alloc_skb(FEC_RX_BUFFER_SIZE);
> > + if (skb == 0)
>
> Test against NULL
Right. I also fixed other stuff sparse reports.
>
> > + return -EAGAIN;
> > +
...
> > +
> > + if (new_state && netif_msg_link(priv)) {
> > + phy_print_status(phydev);
> > + }
>
> No need for {}, this if has only one statement
OK.
...
> > +static int __init
> > +mpc52xx_fec_init(void)
> > +{
> > + int ret;
> > + if ((ret = fec_mdio_init())) {
>
> Why not:
>
> int ret = fec_mdio_init();
> if (ret) {
>
> Less parenthesis, looks more clear
I prefer it like that too.
Thanks Arnaldo!
Any other comments on code functionality, design?
Domen
next prev parent reply other threads:[~2007-08-13 7:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 9:51 [RFC PATCH v0.1] net driver: mpc52xx fec Domen Puncer
2007-08-10 13:02 ` Arnaldo Carvalho de Melo
2007-08-13 7:21 ` Domen Puncer [this message]
2007-09-02 7:41 ` [RFC PATCH v0.2] " Domen Puncer
2007-09-03 15:57 ` Grant Likely
2007-09-03 16:09 ` Jon Smirl
2007-09-03 16:41 ` Grant Likely
2007-09-15 12:14 ` Domen Puncer
2007-09-17 9:53 ` Sven Luther
2007-09-17 20:21 ` [PATCH] phy: export phy_mii_ioctl Domen Puncer
2007-09-17 22:08 ` Jon Smirl
2007-09-18 15:16 ` Domen Puncer
2007-09-18 19:17 ` Jon Smirl
2007-09-19 11:56 ` Domen Puncer
2007-09-19 18:44 ` Jon Smirl
2007-09-19 21:18 ` Jon Smirl
2007-09-18 19:29 ` Jon Smirl
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-19 10:37 ` Juergen Beisert
2007-09-19 13:56 ` Jon Smirl
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-20 6:36 ` Jeff Garzik
2007-10-02 12:49 ` [RFC PATCH v0.2] net driver: mpc52xx fec Sascha Hauer
2007-10-02 14:32 ` Domen Puncer
2007-10-02 15:46 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070813072131.GD13994@moe.telargo.com \
--to=domen.puncer@telargo$(echo .)com \
--cc=acme@ghostprotocols$(echo .)net \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox