From: Paul Mundt <lethal@linux-sh•org>
To: Joe Perches <joe@perches•com>, Andy Whitcroft <apw@shadowen•org>
Cc: Dave Jones <davej@redhat•com>,
Linux Kernel <linux-kernel@vger•kernel.org>,
rolandd@cisco•com, Chas Williams <chas@cmf•nrl.navy.mil>,
isdn4linux@listserv•isdn4linux.de, mikep@linuxtr•net,
netdev@vger•kernel.org, swen@vnet•ibm.com, linux390@de•ibm.com,
linux-s390@vger•kernel.org, jdike@karaya•com,
user-mode-linux-devel@lists•sourceforge.net,
user-mode-linux-user@lists•sourceforge.net,
netfilter-devel@lists•netfilter.org, coreteam@netfilter•org,
Randy Dunlap <rdunlap@xenotime•net>,
Andrew Morton <akpm@osdl•org>
Subject: Re: drivers/infiniband/mlx/mad.c misplaced ;
Date: Fri, 17 Aug 2007 01:19:37 +0900 [thread overview]
Message-ID: <20070816161937.GA15530@linux-sh.org> (raw)
In-Reply-To: <exportbomb.1187270320@pinky> <1187224811.5906.55.camel@localhost>
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote:
> $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" *
> arch/sh/boards/se/7343/io.c: if (0) ;
> drivers/atm/iphase.c: if (!desc1) ;
> drivers/infiniband/hw/mlx4/mad.c: if (!err);
> drivers/isdn/capi/capiutil.c: else if (c <= 0x0f);
> drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == 0xf); /* No paging in adapter */
> drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; /* no further action */
> fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ;
> net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4);
> sound/pci/au88x0/au88x0_synth.c: if (eax == 0) ;
On Thu, Aug 16, 2007 at 02:18:40PM +0100, Andy Whitcroft wrote:
> A couple of people suggested adding checks to checkpatch for trailing
> semicolons on conditionals, where the conditional block may not be
> actually conditional:
>
> if (err);
> return err;
>
> While regression testing the changes, I ran these checks across the
> whole of 2.6.23-rc3 and there appear to be 5 places where this is
> occurs (above and beyond the IPv6 one which triggered this effort)
> and a benign use which could be confused later which it seems safest
> to fix.
>
> Following this email are 6 patches for these issues, relevant
> maintainers cc'd. All against 2.6.23-rc3
>
It looks like you may want to refine your search parameters to match the
above, as there are at least a few cases where the space exists.
prev parent reply other threads:[~2007-08-16 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070815235825.GB17004@redhat.com>
2007-08-16 0:40 ` drivers/infiniband/mlx/mad.c misplaced ; Joe Perches
2007-08-16 2:19 ` Kok, Auke
2007-08-16 14:05 ` Andy Whitcroft
2007-08-16 8:46 ` Heiko Carstens
2007-08-16 10:22 ` Ilpo Järvinen
2007-08-16 11:01 ` Karsten Keil
2007-08-18 15:14 ` Daniel Schaffrath
2007-08-16 12:41 ` Satyam Sharma
2007-08-16 14:52 ` Jeff Dike
2007-08-16 16:19 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816161937.GA15530@linux-sh.org \
--to=lethal@linux-sh$(echo .)org \
--cc=akpm@osdl$(echo .)org \
--cc=apw@shadowen$(echo .)org \
--cc=chas@cmf$(echo .)nrl.navy.mil \
--cc=coreteam@netfilter$(echo .)org \
--cc=davej@redhat$(echo .)com \
--cc=isdn4linux@listserv$(echo .)isdn4linux.de \
--cc=jdike@karaya$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=mikep@linuxtr$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@lists$(echo .)netfilter.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=rolandd@cisco$(echo .)com \
--cc=swen@vnet$(echo .)ibm.com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox