From: Stephen Hemminger <shemminger@linux-foundation•org>
To: Jeff Garzk <jgarzik@pobox•com>
Cc: netdev@vger•kernel.org
Subject: [PATCH 2/6] sky2: ethtool speed report bug
Date: Wed, 19 Sep 2007 22:06:01 -0700 [thread overview]
Message-ID: <20070920050700.384830557@linux-foundation.org> (raw)
In-Reply-To: 20070920050559.763089637@linux-foundation.org
[-- Attachment #1: sky2-ethtool-100mbit.patch --]
[-- Type: text/plain, Size: 874 bytes --]
On 100mbit versions, the driver always reports gigabit speed
available. The correct modes are already computed, then overwritten.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation•org>
--- a/drivers/net/sky2.c 2007-09-19 21:35:53.000000000 -0700
+++ b/drivers/net/sky2.c 2007-09-19 21:35:57.000000000 -0700
@@ -2880,13 +2880,6 @@ static int sky2_get_settings(struct net_
ecmd->supported = sky2_supported_modes(hw);
ecmd->phy_address = PHY_ADDR_MARV;
if (sky2_is_copper(hw)) {
- ecmd->supported = SUPPORTED_10baseT_Half
- | SUPPORTED_10baseT_Full
- | SUPPORTED_100baseT_Half
- | SUPPORTED_100baseT_Full
- | SUPPORTED_1000baseT_Half
- | SUPPORTED_1000baseT_Full
- | SUPPORTED_Autoneg | SUPPORTED_TP;
ecmd->port = PORT_TP;
ecmd->speed = sky2->speed;
} else {
--
Stephen Hemminger <shemminger@linux-foundation•org>
next prev parent reply other threads:[~2007-09-20 5:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 5:05 [PATCH 0/6] sky2: merged for netdev-2.6 upstream Stephen Hemminger
2007-09-20 5:06 ` [PATCH 1/6] sky2: fix VLAN receive processing Stephen Hemminger
2007-09-20 5:06 ` Stephen Hemminger [this message]
2007-09-20 5:06 ` [PATCH 3/6] sky2: reorganize chip revision features Stephen Hemminger
2007-09-20 5:06 ` [PATCH 4/6] sky2: fe+ chip support Stephen Hemminger
2007-09-20 5:06 ` [PATCH 5/6] sky2: receive FIFO checking Stephen Hemminger
2007-09-20 5:06 ` [PATCH 6/6] sky2: version 1.18 Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2007-09-19 22:36 [PATCH 0/6] sky2: version 1.18 (rev2) Stephen Hemminger
2007-09-19 22:36 ` [PATCH 2/6] sky2: ethtool speed report bug Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920050700.384830557@linux-foundation.org \
--to=shemminger@linux-foundation$(echo .)org \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox