public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom•net>
To: jgarzik@pobox•com
Cc: netdev@vger•kernel.org
Subject: [PATCH] [5/6] pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long
Date: Wed, 26 Sep 2007 16:23:59 -0500	[thread overview]
Message-ID: <20070926212359.GE24168@lixom.net> (raw)
In-Reply-To: <20070926212200.GA24168@lixom.net>

pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long.

Signed-off-by: Tony Breeds <tony@bakeyournoodle•com>
Signed-off-by: Olof Johansson <olof@lixom•net>

---
Found trying to build a -rt kernel, which has a BUILD_BUG_ON(), in this
caswe.

 drivers/net/pasemi_mac.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: k.org/drivers/net/pasemi_mac.c
===================================================================
--- k.org.orig/drivers/net/pasemi_mac.c
+++ k.org/drivers/net/pasemi_mac.c
@@ -557,7 +557,7 @@ static int pasemi_mac_clean_tx(struct pa
 	struct pas_dma_xct_descr *dp;
 	unsigned int start, count, limit;
 	unsigned int total_count;
-	int flags;
+	unsigned long flags;
 	struct sk_buff *skbs[32];
 	dma_addr_t dmas[32];
 
@@ -978,7 +978,7 @@ static int pasemi_mac_start_tx(struct sk
 	struct pas_dma_xct_descr *dp;
 	u64 dflags, mactx, ptr;
 	dma_addr_t map;
-	int flags;
+	unsigned long flags;
 
 	dflags = XCT_MACTX_O | XCT_MACTX_ST | XCT_MACTX_SS | XCT_MACTX_CRC_PAD;
 

  parent reply	other threads:[~2007-09-26 21:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 21:22 [PATCH] [0/6] Bugfixes for pasemi_mac Olof Johansson
2007-09-26 21:22 ` [PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe() Olof Johansson
2007-09-26 21:22   ` David Miller
2007-09-26 21:23 ` [PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx() Olof Johansson
2007-09-26 21:24   ` David Miller
2007-09-26 21:23 ` [PATCH] [3/6] pasemi_mac: set interface speed correctly on XAUI ports Olof Johansson
2007-09-29  4:45   ` Jeff Garzik
2007-09-26 21:23 ` Olof Johansson [this message]
2007-09-26 21:24 ` [PATCH] [5/6] pasemi_mac: don't enable rx before there are buffers on the ring Olof Johansson
2007-09-26 21:25 ` [PATCH] [6/6] pasemi_mac: pass in count of buffers to replenish rx ring with Olof Johansson
2007-09-26 21:26 ` [PATCH] [0/6] Bugfixes for pasemi_mac David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070926212359.GE24168@lixom.net \
    --to=olof@lixom$(echo .)net \
    --cc=jgarzik@pobox$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox