From: Grant Grundler <grundler@parisc-linux•org>
To: Jeff Garzik <jeff@garzik•org>
Cc: Zang Roy-r61911 <tie-fei.zang@freescale•com>,
Andrew Morton <akpm@osdl•org>, netdev <netdev@vger•kernel.org>,
Kyle McMartin <kyle@mcmartin•ca>,
Grant Grundler <grundler@parisc-linux•org>
Subject: Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
Date: Thu, 27 Sep 2007 21:57:43 -0600 [thread overview]
Message-ID: <20070928035743.GD14312@colo.lackof.org> (raw)
In-Reply-To: <46FC76DA.6030906@garzik.org>
On Thu, Sep 27, 2007 at 11:36:58PM -0400, Jeff Garzik wrote:
> Zang Roy-r61911 wrote:
>> From: Roy Zang <tie-fei.zang@freescale•com>
>> Clean up redundant PHY write line for ULi526x Ethernet
>> Driver.
>> Signed-off-by: Roy Zang <tie-fei.zang@freescale•com>
>> ---
>> drivers/net/tulip/uli526x.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>> diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
>> index ca2548e..53a8e65 100644
>> --- a/drivers/net/tulip/uli526x.c
>> +++ b/drivers/net/tulip/uli526x.c
>> @@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct
>> uli526x_board_info *db)
>> case ULI526X_100MFD: phy_reg = 0x2100; break;
>> }
>> phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
>> - phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
>
> Kyle and Grant, I'll queue this up, unless ya'll object...
please do, I've already Ack'd it for akpm's tree when he sent out the
initial cc.
thanks,
grant
>
> Jeff
>
next prev parent reply other threads:[~2007-09-28 4:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 8:57 [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver Zang Roy-r61911
2007-09-28 3:36 ` Jeff Garzik
2007-09-28 3:57 ` Grant Grundler [this message]
2007-09-29 4:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928035743.GD14312@colo.lackof.org \
--to=grundler@parisc-linux$(echo .)org \
--cc=akpm@osdl$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=kyle@mcmartin$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tie-fei.zang@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox