From: akpm@linux-foundation•org
To: jeff@garzik•org
Cc: netdev@vger•kernel.org, akpm@linux-foundation•org,
micah.gruber@gmail•com, grundler@parisc-linux•org,
kyle@mcmartin•ca
Subject: [patch 06/13] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c
Date: Tue, 02 Oct 2007 14:11:38 -0700 [thread overview]
Message-ID: <200710022111.l92LBcIs022492@imap1.linux-foundation.org> (raw)
From: Micah Gruber <micah.gruber@gmail•com>
This patch fixes an apparent potential null dereference bug where we
dereference dev before a null check. This patch simply remvoes the
can't-happen test for a null pointer.
Signed-off-by: Micah Gruber <micah.gruber@gmail•com>
Cc: Grant Grundler <grundler@parisc-linux•org>
Acked-by: Jeff Garzik <jeff@garzik•org>
Acked-by: Kyle McMartin <kyle@mcmartin•ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
drivers/net/tulip/uli526x.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt drivers/net/tulip/uli526x.c
--- a/drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt
+++ a/drivers/net/tulip/uli526x.c
@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int
unsigned long ioaddr = dev->base_addr;
unsigned long flags;
- if (!dev) {
- ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
- return IRQ_NONE;
- }
-
spin_lock_irqsave(&db->lock, flags);
outl(0, ioaddr + DCR7);
_
next reply other threads:[~2007-10-02 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 21:11 akpm [this message]
2007-10-02 21:20 ` [patch 06/13] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710022111.l92LBcIs022492@imap1.linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=grundler@parisc-linux$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=kyle@mcmartin$(echo .)ca \
--cc=micah.gruber@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox