From: Evgeniy Polyakov <johnpol@2ka•mipt.ru>
To: Satoshi OSHIMA <satoshi.oshima.fk@hitachi•com>
Cc: Andi Kleen <andi@firstfloor•org>,
David Miller <davem@davemloft•net>,
Herbert Xu <herbert@gondor•apana.org.au>,
netdev <netdev@vger•kernel.org>, ?? ?? <yoshfuji@linux-ipv6•org>,
Yumiko SUGITA <yumiko.sugita.yf@hitachi•com>,
"??@RedHat" <haoki@redhat•com>
Subject: Re: [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable
Date: Sun, 7 Oct 2007 14:09:38 +0400 [thread overview]
Message-ID: <20071007100938.GA24475@2ka.mipt.ru> (raw)
In-Reply-To: <470651B3.6060001@hitachi.com>
Hi.
On Sat, Oct 06, 2007 at 12:01:07AM +0900, Satoshi OSHIMA (satoshi.oshima.fk@hitachi•com) wrote:
> --- 2.6.23-rc3-udp_limit.orig/net/ipv4/udp.c
> +++ 2.6.23-rc3-udp_limit/net/ipv4/udp.c
> @@ -113,6 +113,10 @@ DEFINE_SNMP_STAT(struct udp_mib, udp_sta
> struct hlist_head udp_hash[UDP_HTABLE_SIZE];
> DEFINE_RWLOCK(udp_hash_lock);
>
> +atomic_t udp_memory_allocated;
> +
> +EXPORT_SYMBOL(udp_memory_allocated);
> +
Why do you export this variable?
It is not accessed from modules in your patchset.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-10-07 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 14:59 [RFC/PATCH 0/4]UDP memory accounting (take 4) Satoshi OSHIMA
2007-10-05 15:00 ` [RFC/PATCH 1/4] UDP memory usage accounting (take 4): fix send buffer check Satoshi OSHIMA
2007-10-05 15:01 ` [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable Satoshi OSHIMA
2007-10-07 10:09 ` Evgeniy Polyakov [this message]
2007-10-10 8:14 ` Satoshi OSHIMA
2007-10-05 15:02 ` [RFC/PATCH 3/4] UDP memory usage accounting (take 4): memory usage accounting Satoshi OSHIMA
2007-10-05 15:02 ` [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation Satoshi OSHIMA
2007-10-05 15:52 ` Stephen Hemminger
2007-10-11 12:51 ` Satoshi OSHIMA
2007-10-11 19:46 ` Stephen Hemminger
2007-10-12 11:58 ` Satoshi OSHIMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007100938.GA24475@2ka.mipt.ru \
--to=johnpol@2ka$(echo .)mipt.ru \
--cc=andi@firstfloor$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=haoki@redhat$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=satoshi.oshima.fk@hitachi$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yumiko.sugita.yf@hitachi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox