Subject: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

From: David Miller <[email-masked]>
Date: Mon, 08 Oct 2007 19:47:06 -0700 (PDT)

From: Herbert Xu <[email-masked]>
Date: Tue, 9 Oct 2007 10:16:20 +0800

> On Mon, Oct 08, 2007 at 10:14:30PM -0400, jamal wrote:
> >
> > You forgot QDISC_RUNNING Dave;-> the above cant happen. 
> > Essentially at any one point in time, we are guaranteed that we can have
> > multiple cpus enqueueing but only can be dequeueing (the one that
> > managed to grab QDISC_RUNNING) i.e multiple producers to the qdisc queue
> > but only one consumer. Only the dequeuer has access to the txlock.
> 
> Good point.  You had me worried for a sec :)
> 
> Dave, Jamal's patch is fine as it is and doesn't actually create
> any packet reordering.

Ok, then, I'll un-revert. :-)