Subject: Re: [PATCH] USB: net: Fix asix read transfer buffer allocations.

From: Oliver Neukum <[email-masked]>
Date: Mon, 22 Oct 2007 19:29:03 +0200

Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
>  static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
>  {
>         struct usbnet *dev = netdev_priv(netdev);
> +       void *buf;
>         u16 res;
>  
>         mutex_lock(&dev->phy_mutex);
>         asix_set_sw_mii(dev);
> +
> +       buf = kmalloc(2, GFP_KERNEL);

This is done under lock. Can you allocate the buffer once and reuse it?

	Regards
		Oliver

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email-masked]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel