Subject: Re: [PATCH] net: Marking struct pernet_operations __net_initdata was inappropriate

From: David Miller <[email-masked]>
Date: Fri, 26 Oct 2007 22:55:16 -0700 (PDT)

From: [email-masked] (Eric W. Biederman)
Date: Fri, 26 Oct 2007 17:45:33 -0600

> 
> It is not safe to to place struct pernet_operations in a special section.
> We need struct pernet_operations to last until we call unregister_pernet_subsys.
> Which doesn't happen until module unload.
> 
> So marking struct pernet_operations is a disaster for modules in two ways.
> - We discard it before we call the exit method it points to.
> - Because I keep struct pernet_operations on a linked list discarding
>   it for compiled in code removes elements in the middle of a linked
>   list and does horrible things for linked insert.
> 
> So this looks safe assuming __exit_refok is not discarded
> for modules.
> 
> Signed-off-by: Eric W. Biederman <[email-masked]>

Applied, thanks Eric.

Although juding by his comments I though that Denis had different
plans in mind to fix this.