Subject: Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

From: Mark Fasheh <[email-masked]>
Date: Sun, 11 Nov 2007 10:03:41 -0800

On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote:
> From: Trond Myklebust <[email-masked]>
> 
> ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers.
> 
> Looking at the sock->op->shutdown() handlers, it looks as if all of them
> take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the
> RCV_SHUTDOWN/SEND_SHUTDOWN arguments.
> Add a helper, and then define the SHUT_* enum to ensure that kernel users
> of shutdown() don't get confused.

That looks pretty good - any objection to naming the enum and using that
name in the prototype for kernel_sock_shutdown() so it's even more obvious
what type of shutdown argument this expects?
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
[email-masked]