Subject: Re: [PATCH] via-velocity: don't oops on MTU change.

From: Jarek Poplawski <[email-masked]>
Date: Thu, 15 Nov 2007 09:26:00 +0100

On 15-11-2007 04:38, Stephen Hemminger wrote:
> Simple mtu change when device is down.
> Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>
> 
> 
> --- a/drivers/net/via-velocity.c	2007-10-22 09:38:11.000000000 -0700
> +++ b/drivers/net/via-velocity.c	2007-11-14 19:34:30.000000000 -0800
> @@ -1963,6 +1963,11 @@ static int velocity_change_mtu(struct ne
>  		return -EINVAL;
>  	}
>  
> +	if (!netif_running(dev)) {
> +		dev->mtu = new_mtu;
> +		return 0;
> +	}
> +
>  	if (new_mtu != oldmtu) {
>  		spin_lock_irqsave(&vptr->lock, flags);

Shouldn't this latter 'if' be removed now, btw?

Regards,
Jarek P.