Subject: Re: [patch 3/8] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

From: Andrew Morton <[email-masked]>
Date: Fri, 23 Nov 2007 18:04:58 -0800

On Fri, 23 Nov 2007 20:58:51 -0500 Jeff Garzik <[email-masked]> wrote:

> [email-masked] wrote:
> > From: Andrew Morton <[email-masked]>
> > 
> > Cc: "David S. Miller" <[email-masked]>
> > Cc: Emil Medve <[email-masked]>
> > Cc: Jeff Garzik <[email-masked]>
> > Cc: Kumar Gala <[email-masked]>
> > Cc: Li Yang <[email-masked]>
> > Cc: Paul Mackerras <[email-masked]>
> > Signed-off-by: Andrew Morton <[email-masked]>
> > ---
> > 
> >  drivers/net/ucc_geth.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff -puN drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes drivers/net/ucc_geth.c
> > --- a/drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes
> > +++ a/drivers/net/ucc_geth.c
> > @@ -3443,7 +3443,7 @@ static int ucc_geth_rx(struct ucc_geth_p
> >  	u16 length, howmany = 0;
> >  	u32 bd_status;
> >  	u8 *bdBuffer;
> > -	struct net_device * dev;
> > +	struct net_device *dev;
> 
> ACK with a fixed description...
> 

Well...  I do these little fixups

a) to remind originators that they should be checking their stuff with
checkpatch

b) to fold into the offending base patch prior to sending upstream

c) to let upstream (in this case you) know that the patch had coding-style
problems.

as it appears that you merged the base patch without noticing the error,
and without running checkpatch I don't think it's worth merging a silly
one-liner like this on its own.