Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down

From: Andrew Morton <[email-masked]>
Date: Thu, 13 Dec 2007 16:30:46 -0800

On Thu, 13 Dec 2007 16:11:55 -0800
"Ayaz Abdulla" <[email-masked]> wrote:

> I would not include this patch until further testing is performed.
> NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it
> could have adverse affects on certain phys.
> 
> Ayaz
> 
> 
> -----Original Message-----
> From: [email-masked] [mailto:[email-masked]] 
> Sent: Thursday, December 13, 2007 4:03 PM
> To: [email-masked]
> Cc: [email-masked]; [email-masked];
> [email-masked]; Ayaz Abdulla
> Subject: [patch 02/10] forcedeth: power down phy when interface is down
> 
> 
> From: "Ed Swierk" <[email-masked]>
> 
> Bring the physical link down when the interface is down by placing the
> PHY
> in power-down state, unless WOL is enabled.  This mirrors the behavior
> of
> other drivers including e1000 and tg3.

Does this patch actually fix any observeable problem?