From: Ben Hutchings <bhutchings@solarflare•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: netdev@vger•kernel.org, linux-net-drivers@solarflare•com
Subject: Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller - 3nd try
Date: Fri, 21 Dec 2007 18:30:07 +0000 [thread overview]
Message-ID: <20071221183006.GA8717@solarflare.com> (raw)
In-Reply-To: <20071221100253.fb5b0899.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> On Fri, 21 Dec 2007 16:53:40 +0000 Robert Stonehouse wrote:
>
> > This is a resubmission of a new driver for Solarflare network controllers.
<snip>
> > The last two patches were marked with RFC but I now think that this driver
> > is ready (withstanding any further review comments) and I would like to ask
> > that this driver is considered for merging.
> >
> >
> > The patch (against net-2.6.25) is at:
> > https://support.solarflare.com/netdev/3/net-2.6.25-sfc-2.2.0029.patch
>
> wow, 750+ KB
>
> How many drivers is this?
Just two: sfc (net) and sfc_mtd (MTD). As Robert said, the net driver
supports a variety of PHYs. It also has a fair amount of self-test
and (conditional) debug code, and comments.
I've noted your comments on kernel-doc and Kconfig format and will
address those in the next version.
<snip>
> c. Driver contains MTD, SPI, & I2C (at least) code and needs to be
> reviewed by people in those areas as well (IMO).
>
> I see an MTD dependency in the Kconfig file.
> What about the SPI and I2C parts? Are they conditional or
> how is that handled? or does the driver not use the kernel
> infrastructure for these?
We are not currently using the kernel infrastructure for those.
I'm not sure whether we could do.
I think everyone working on the net driver here will be away until
the new year, so please forgive our silence in the mean time.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
prev parent reply other threads:[~2007-12-21 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 16:53 [PATCH] New driver "sfc" for Solarstorm SFC4000 controller - 3nd try Robert Stonehouse
2007-12-21 18:02 ` Randy Dunlap
2007-12-21 18:30 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221183006.GA8717@solarflare.com \
--to=bhutchings@solarflare$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox