Subject: Re: [PATCH 01/14] Fix sparse warning: returning void-valued expression

From: David Brownell <david-b-yBeKhBN/[email-masked]>
Date: Thu, 24 Jan 2008 16:52:12 -0800

On Saturday 19 January 2008, Jussi Kivilinna wrote:
> From: Bjorge Dijkstra <[email-masked]>
> 
> rndis_unbind and usbnet_cdc_unbind don't return anything.
> 
> Signed-off-by: Bjorge Dijkstra <[email-masked]>
> Signed-off-by: Jussi Kivilinna <[email-masked]>

Acked-by: David Brownell <[email-masked]>

> ---
> 
>  drivers/net/usb/rndis_host.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
> index 1ebe325..96ef6a9 100644
> --- a/drivers/net/usb/rndis_host.c
> +++ b/drivers/net/usb/rndis_host.c
> @@ -585,7 +585,7 @@ static void rndis_unbind(struct usbnet *dev, struct usb_interface *intf)
>  		kfree(halt);
>  	}
>  
> -	return usbnet_cdc_unbind(dev, intf);
> +	usbnet_cdc_unbind(dev, intf);
>  }
>  
>  /*
>