Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization

From: Jens Osterkamp <jens@de•ibm.com>
To: Jeff Garzik <jgarzik@pobox•com>
Cc: cbe-oss-dev@ozlabs•org, netdev@vger•kernel.org,
	Ishizaki Kou <kou.ishizaki@toshiba•co.jp>
Subject: Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization
Date: Mon, 28 Jan 2008 14:40:48 +0100	[thread overview]
Message-ID: <200801281440.48602.jens@de.ibm.com> (raw)
In-Reply-To: <200801231453.42736.jens@de.ibm.com>

Jeff,

this series of 5 patches by Ishizaki-san runs fine on the blade, I tested it
for a few days. Besides it fixes a nasty bug in spidernet RX descriptor handling.

Can you please consider it for 2.6.25 ?

Thanks !

Jens

On Wednesday 23 January 2008, Jens Osterkamp wrote:
> On Friday 11 January 2008, Ishizaki Kou wrote:
> > This patch fixes initialization of "aneg_count" and "medium" fields in
> > spider_net_card to make spidernet driver correctly sets "link status".
> > 
> > Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba•co.jp>
> 
> Acked-by: Jens Osterkamp <jens@de•ibm.com>
> 
> > ---
> > 
> > Index: linux-powerpc-git/drivers/net/spider_net.c
> > ===================================================================
> > --- linux-powerpc-git.orig/drivers/net/spider_net.c
> > +++ linux-powerpc-git/drivers/net/spider_net.c
> > @@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device 
> >  	spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
> > 
> >  	/* reset phy and setup aneg */
> > +	card->aneg_count = 0;
> > +	card->medium = BCM54XX_COPPER;
> >  	spider_net_setup_aneg(card);
> >  	mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> > 
> > @@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
> >  		goto init_firmware_failed;
> > 
> >  	/* start probing with copper */
> > +	card->aneg_count = 0;
> > +	card->medium = BCM54XX_COPPER;
> >  	spider_net_setup_aneg(card);
> >  	if (card->phy.def->phy_id)
> >  		mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> > _______________________________________________
> > cbe-oss-dev mailing list
> > cbe-oss-dev@ozlabs•org
> > https://ozlabs.org/mailman/listinfo/cbe-oss-dev
> >

-- 

Gruß,

Jens

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294