Subject: Re: [PATCH] request_irq() always returns -EINVAL with a NULL handler.

From: Andrew Morton <[email-masked]>
Date: Sat, 2 Feb 2008 22:15:02 -0800

On Thu, 17 Jan 2008 17:57:58 +1100 Rusty Russell <[email-masked]> wrote:

> I assume that these ancient network drivers were trying to find out if
> an irq is available.  eepro.c expecting +EBUSY was doubly wrong.
> 
> I'm not sure that can_request_irq() is the right thing, but these drivers
> are definitely wrong.
> 
> request_irq should BUG() on bad input, and these would have been found
> earlier.

This breaks non-CONFIG_GENERIC_HARDIRQS architectures.

alpha:

drivers/net/3c503.c: In function 'el2_open':
drivers/net/3c503.c:382: error: implicit declaration of function 'can_request_irq'