From: David Brownell <david-b@pacbell•net>
To: Claudio Lanconelli <lanconelli.claudio@eptar•com>
Cc: netdev@vger•kernel.org
Subject: Re: [patch 2.6.24-git] net/enc28j60: oops fix, low power mode
Date: Mon, 11 Feb 2008 12:23:49 -0800 [thread overview]
Message-ID: <200802111223.49823.david-b@pacbell.net> (raw)
In-Reply-To: <47B03A9A.2060605@eptar.com>
On Monday 11 February 2008, Claudio Lanconelli wrote:
> I have tried your latest patch. Only after the following change it
> works fine (no more rx errors during ifconfig up).
Hmm, what chip rev do you have? Different errata and all.
ISTR mine is rev4; so, not the most current, but not the
oldest version either.
> I added enc28j60_lowpower(false) just before enc28j60_hw_init()
Hmm, I'd have expected it would go best *before* that, but
what you include below shows it going *after* ...
If there's some problem where reset doesn't work correctly
in low power mode, who knows what else would need manual
resetting.
> @@ -1318,8 +1347,9 @@
> }
> return -EADDRNOTAVAIL;
> }
> - /* Reset the hardware here */
> + /* Reset the hardware here (and take it out of low power mode) */
> enc28j60_hw_disable(priv);
> + enc28j60_lowpower(priv, false);
> if (!enc28j60_hw_init(priv)) {
> if (netif_msg_ifup(priv))
> dev_err(&dev->dev, "hw_reset() failed\n");
>
> With this addition you can add Acked-by line.
Better yet, since I can't reproduce the problem, why don't
you just update my latest patch with the relevant version
of this tweak, and then forward it as "From: " me and with
both our signoffs. That's the usual way to cope with this
type of tweaking. (Not all updates to your driver should
need your signoff, but then most patches shouldn't need
very many iterations either.)
- Dave
next prev parent reply other threads:[~2008-02-11 20:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 19:01 [patch 2.6.24-git] net/enc28j60: oops fix, low power mode David Brownell
2008-02-06 17:11 ` Claudio Lanconelli
2008-02-06 17:33 ` [patch 2.6.24-git] net/enc28j60: oops fix David Brownell
2008-02-07 10:24 ` Claudio Lanconelli
2008-02-19 20:52 ` [RESEND/patch 2.6.25-rc2-git] " David Brownell
2008-03-05 1:17 ` [RE(*2)SEND/patch " David Brownell
2008-03-06 2:52 ` David Miller
2008-03-06 3:05 ` David Brownell
2008-02-06 18:19 ` [patch 2.6.24-git] net/enc28j60: low power mode David Brownell
2008-02-07 10:49 ` Claudio Lanconelli
2008-02-07 5:56 ` [patch 2.6.24-git] net/enc28j60: oops fix, " David Brownell
2008-02-07 10:53 ` Claudio Lanconelli
2008-02-10 17:54 ` David Brownell
2008-02-11 12:07 ` Claudio Lanconelli
2008-02-11 20:23 ` David Brownell [this message]
2008-02-14 10:28 ` Claudio Lanconelli
2008-02-07 6:08 ` [patch 2.6.24-git] net/enc28j60: " David Brownell
2008-02-07 11:21 ` Claudio Lanconelli
2008-02-10 17:45 ` David Brownell
2008-02-10 17:46 ` David Brownell
2008-02-07 6:08 ` [patch 2.6.24-git] net/enc28j60: section fix David Brownell
2008-02-07 11:13 ` Claudio Lanconelli
2008-02-19 20:54 ` [RESEND/patch 2.6.25-rc2-git] net/enc28j60: low power mode David Brownell
2008-02-19 20:56 ` [RESEND/patch 2.6.25-rc2-git] net/enc28j60: section fix David Brownell
2008-04-19 2:08 ` [RESEND/patch 2.6.25] " David Brownell
2008-04-19 2:08 ` [RESEND/patch 2.6.25] net/enc28j60: low power mode David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802111223.49823.david-b@pacbell.net \
--to=david-b@pacbell$(echo .)net \
--cc=lanconelli.claudio@eptar$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox