From: Michael Buesch <mb@bu3sch•de>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks•co.jp>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] add pcibios_enable_device() return value check
Date: Thu, 28 Feb 2008 22:54:52 +0100 [thread overview]
Message-ID: <200802282254.52426.mb@bu3sch.de> (raw)
In-Reply-To: <20080228221538.058d1f40.yoichi_yuasa@tripeaks.co.jp>
On Thursday 28 February 2008 14:15:38 Yoichi Yuasa wrote:
> This patch has added pcibios_enable_device() return value check.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks•co.jp>
>
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/ssb/driver_pcicore.c linux/drivers/ssb/driver_pcicore.c
> --- linux-orig/drivers/ssb/driver_pcicore.c 2008-02-26 15:51:13.146734949 +0900
> +++ linux/drivers/ssb/driver_pcicore.c 2008-02-26 15:54:29.257910690 +0900
> @@ -111,7 +111,8 @@ static void __init ssb_fixup_pcibridge(s
>
> /* Enable PCI bridge bus mastering and memory space */
> pci_set_master(dev);
> - pcibios_enable_device(dev, ~0);
> + if (pcibios_enable_device(dev, ~0) < 0)
> + return;
I'm not sure if we really want to silently fail here.
Please add this:
ssb_printk(KERN_ERR "PCI: SSB bridge enable failed\n");
> /* Enable PCI bridge BAR1 prefetch and burst */
> pci_write_config_dword(dev, SSB_BAR1_CONTROL, 3);
--
Greetings Michael.
next prev parent reply other threads:[~2008-02-28 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 13:15 [PATCH] add pcibios_enable_device() return value check Yoichi Yuasa
2008-02-28 21:54 ` Michael Buesch [this message]
2008-02-29 2:45 ` [PATCH UPDATE] " Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802282254.52426.mb@bu3sch.de \
--to=mb@bu3sch$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoichi_yuasa@tripeaks$(echo .)co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox