Subject: Re: [PATCH] Re: WAN: new PPP code for generic HDLC

From: Stephen Hemminger <[email-masked]>
Date: Wed, 12 Mar 2008 11:52:15 -0700

> +struct hdlc_header {
> +	u8 address;
> +	u8 control;
> +	__be16 protocol;
> +} __attribute__ ((packed));
> +
> +struct cp_header {
> +	u8 code;
> +	u8 id;
> +	__be16 len;
> +} __attribute__ ((packed));
> +

If I remember correctly, the packed is unnecessary for structures like this
and causes GCC to generate worse code.