Subject: Re: 2.6.25-rc: Null dereference in ip_defrag

From: Phil Oester <[email-masked]>
Date: Mon, 17 Mar 2008 12:40:14 -0700

On Mon, Mar 17, 2008 at 06:43:32PM +0100, Patrick McHardy wrote:
> Pavel Emelyanov wrote:
> > Can you check with this patch, please (untested, but should work)?
> 
> This is getting pretty ugly. Shouldn't
> 
> int ip_defrag(struct sk_buff *skb, u32 user)
> {
> ...
> -         net = skb->dev->nd_net;
> +         net = skb->dev ? skb->dev->nd_net : skb->dst->dev->nd_net;
> 
> work as well?

I can try either patch, but Patrick's looks simpler and thus perhaps
a better candidate this late in the -rc stage.

Pavel - you concur?

Phil