From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public•gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>
Cc: Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public•gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public•gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Ingo Molnar <mingo-X9Un+BFzKDI@public•gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Martin Schwidefsky
<schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public•gmane.org>,
Heiko Carstens
<heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public•gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org,
Stefan Richter
<stefanr-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public•gmane.org>,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public•gmane.org
Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c
Date: Fri, 21 Mar 2008 10:04:04 -0700 [thread overview]
Message-ID: <200803211004.05106.david-b@pacbell.net> (raw)
In-Reply-To: <20080320180802.426ad2d1.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
On Thursday 20 March 2008, Andrew Morton wrote:
> ./drivers/net/usb/pegasus.c
>
> Possibly buggy: deadlockable (I assume)
Looks just unecessary to me ... ethtool MII ops get called from
a task context, as I recall, and other drivers just rely on that.
- Dave
========= CUT HERE
Remove superfluous in-atomic() check; ethtool MII ops are called
from task context.
Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public•gmane.org>
---
drivers/net/usb/pegasus.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- g26.orig/drivers/net/usb/pegasus.c 2008-03-21 08:53:28.000000000 -0700
+++ g26/drivers/net/usb/pegasus.c 2008-03-21 08:54:07.000000000 -0700
@@ -1128,12 +1128,8 @@ pegasus_get_settings(struct net_device *
{
pegasus_t *pegasus;
- if (in_atomic())
- return 0;
-
pegasus = netdev_priv(dev);
mii_ethtool_gset(&pegasus->mii, ecmd);
prev parent reply other threads:[~2008-03-21 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080316184349.GA28543@khazad-dum.debian.net>
[not found] ` <200803161246.23909.david-b@pacbell.net>
[not found] ` <20080318001429.896acf51.akpm@linux-foundation.org>
[not found] ` <20080320225612.GB20788@khazad-dum.debian.net>
[not found] ` <20080320164741.734e838c.akpm@linux-foundation.org>
[not found] ` <20080321003604.GC20788@khazad-dum.debian.net>
2008-03-21 1:08 ` use of preempt_count instead of in_atomic() at leds-gpio.c Andrew Morton
[not found] ` <20080320180802.426ad2d1.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-21 1:31 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0803202126240.11234-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-03-21 1:36 ` Michael Buesch
[not found] ` <200803210236.52063.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2008-03-21 2:27 ` Andrew Morton
[not found] ` <20080320192719.6a32386e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-21 3:07 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0803202301140.16520-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-03-21 3:17 ` Andrew Morton
2008-03-21 13:47 ` Heiko Carstens
[not found] ` <20080321134750.GB4128-Pmgahw53EmNLmI7Nx2oIsGnsbthNF6/HVpNB7YpNyf8@public.gmane.org>
2008-03-21 16:54 ` Greg KH
[not found] ` <20080321165405.GC5766-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-03-21 19:59 ` Andrew Morton
[not found] ` <20080321125950.a5b38bda.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-21 20:16 ` Michael Buesch
[not found] ` <200803212116.49462.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2008-03-21 20:20 ` Michael Buesch
2008-03-21 9:21 ` Stefan Richter
[not found] ` <47E37E04.3080303-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org>
2008-03-21 9:27 ` Stefan Richter
2008-03-21 12:37 ` Henrique de Moraes Holschuh
2008-03-21 13:16 ` Stefan Richter
[not found] ` <47E3B528.6010200-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org>
2008-03-22 11:29 ` Stefan Richter
2008-03-21 17:04 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803211004.05106.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public$(echo .)gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public$(echo .)gmane.org \
--cc=heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=hmh-N3TV7GIv+o9fyO9Q7EP/yw@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public$(echo .)gmane.org \
--cc=mingo-X9Un+BFzKDI@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public$(echo .)gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=stefanr-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public$(echo .)gmane.org \
--cc=video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox