From: Ingo Molnar <mingo@elte•hu>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Jeff Garzik <jeff@garzik•org>, David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, aabdulla@nvidia•com,
linux-kernel@vger•kernel.org
Subject: Re: [patch 20/21] forcedeth: fix locking bug with netconsole
Date: Sat, 29 Mar 2008 00:46:28 +0100 [thread overview]
Message-ID: <20080328234628.GA8459@elte.hu> (raw)
In-Reply-To: <20080328164209.e8b723d8.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation•org> wrote:
> > > Please do not mix device driver changes with core networking
> > > changes.
> >
> > FWIW my plan was to snip the net/* stuff and only apply the
> > forcedeth portion.
> >
> > (leaving <whomever> to pick up the pieces, should they so desire)
> >
>
> Just drop 'em completely I'd say.
you mean the netpoll.c bits? sure.
> otoh, drivers do seem a bit flakey in the netpoll-support area, so a
> bit of extra debug wouldn't hurt. But checking irqs_disabled() either
> side of a udelay() was a bit paranoid ;)
yeah. i completely forgot about those bits. But lets make sure the
forcedeth.c fix gets into .25 - it's obvious and it fixes a nasty bug.
Without that fix netconsole is unusable on forcedeth.
Ingo
next prev parent reply other threads:[~2008-03-28 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:41 [patch 20/21] forcedeth: fix locking bug with netconsole akpm
2008-03-28 22:43 ` David Miller
2008-03-28 22:48 ` Jeff Garzik
2008-03-28 23:42 ` Andrew Morton
2008-03-28 23:46 ` Ingo Molnar [this message]
2008-03-29 2:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328234628.GA8459@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=aabdulla@nvidia$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jeff@garzik$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox