Subject: Re: arcnet - weird printk arc%d

From: Stephen Hemminger <[email-masked]>
Date: Sat, 12 Apr 2008 18:17:21 -0700

On Sat, 12 Apr 2008 21:07:20 -0400
Dan Noe <[email-masked]> wrote:

> [email-masked] wrote:
> > Apr 13 01:25:50 neo klogd:  arc%d: Given: node 00h, shmem 0h, irq 0
> > Apr 13 01:25:50 neo klogd:  arc%d: No autoprobe for RIM I; you must specify the shmem and irq!
> > Apr 13 01:25:50 neo klogd:  arc%d: No autoprobe for IO mapped cards; you must specify the base address!
> > 
> > arc%d looks weird - is this intenitonal ?
> 
> The %d is normally replaced by the interface number after 
> register_netdev is called.  But these error messages are printed in 
> arcrimi_found() *before* register_netdev() is called (because the device 
> hasn't been found yet).
> 
> I'm not sure what the best approach to fixing this is.  Most likely the 
> log printouts at that point should not be using the macros that rely on 
> dev->name being fully correct.
> 
> Cheers,
> Dan
> 

use dev_info et al, to print out using the bus id.