Subject: Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()

From: Matthew Wilcox <[email-masked]>
Date: Fri, 18 Apr 2008 13:07:29 -0600

On Fri, Apr 18, 2008 at 02:36:46PM -0400, Mark Asselstine wrote:
> -   ns_grab_res_lock(card, flags);
> +   spin_lock_irqsave(&(card)->res_lock,(flags));

We generally prefer the form:

	spin_lock_irqsave(&card->res_lock, flags);

The brackets aren't needed and since they aren't used elsewhere in the
kernel, breaking the pattern makes it look like these are somehow
different (which they aren't).

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."