Subject: Re: [PATCH][NET_SCHED] sch_sfq: use del_timer_sync() in sfq_destroy()

From: Jarek Poplawski <[email-masked]>
Date: Sun, 27 Apr 2008 21:00:44 +0200

On Sun, Apr 27, 2008 at 08:24:34PM +0200, Patrick McHardy wrote:
> Jarek Poplawski wrote:
>> [NET_SCHED] sch_sfq: use del_timer_sync() in sfq_destroy()
>>
>> Let's delete timer reliably in sfq_destroy().
>
> This is broken, we hold dev->queue_lock in ->destroy.
>

But sfq timer (sfq_perturbation()) doesn't use this timer...
Could you explain your point more?

Thanks,
Jarek P.