Subject: [ofa-general] Re: [RESEND] RE: [PATCH 08/13] QLogic VNIC: sysfs interface implementation for the driver

From: Stephen Hemminger <[email-masked]>
Date: Thu, 1 May 2008 11:22:52 -0700

On Thu, 1 May 2008 22:13:08 +0530
"Ramachandra K" <[email-masked]> wrote:

> Sorry for the resend. Original mail got bounced from netdev.
> 
> On Thu, May 1, 2008 at 9:32 PM,  <[email-masked]> wrote:
> >
> > Stephen,
> >
> >
> >  Stephen Hemminger [mailto:[email-masked]] wrote:
> >
> >  >> On Wed, 30 Apr 2008 22:49:55 +0530
> >  >> Ramachandra K <[email-masked]> wrote:
> >
> >  <snip>
> >
> >
> >  >> +static match_table_t vnic_opt_tokens = {
> >  >> +    {VNIC_OPT_IOC_GUID, "ioc_guid=%s"},
> >  >> +    {VNIC_OPT_DGID, "dgid=%s"},
> >  >> +    {VNIC_OPT_PKEY, "pkey=%x"},
> >  >> +    {VNIC_OPT_NAME, "name=%s"},
> >  >> +    {VNIC_OPT_INSTANCE, "instance=%d"},
> >  >> +    {VNIC_OPT_RXCSUM, "rx_csum=%s"},
> >  >> +    {VNIC_OPT_TXCSUM, "tx_csum=%s"},
> >  >> +    {VNIC_OPT_HEARTBEAT, "heartbeat=%d"},
> >  >> +    {VNIC_OPT_IOC_STRING, "ioc_string=\"%s"},
> >  >> +    {VNIC_OPT_IB_MULTICAST, "ib_multicast=%s"},
> >  >> +    {VNIC_OPT_ERR, NULL}
> >  >> +};
> >  >>
> >
> >  > NO
> >  > 1. Most of this shouldn't be done via sysfs (rx_csum, tx_csum, ...)
> >  > 2. Sysfs is one value per file not name=value
> >
> >  The VNIC driver needs multiple parameters (IOCGUID, DGID etc) from user space
> >  to connect to the EVIC. For this the "name=value" mechanism is used for
> >  a write-only sysfs file as an input method to the driver.
> >
> >  The driver follows the one value per file sysfs rule when it returns any data
> >  with each readable file returning only a single value.
> >
> >  Regards,
> >  Ram

The undocumented style rule of sysfs is one value (ascii) per file.