Subject: Re: [ofa-general] RE: [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros

From: Stephen Hemminger <[email-masked]>
Date: Thu, 1 May 2008 11:26:33 -0700

On Thu, 1 May 2008 22:31:10 +0530
"Ramachandra K" <[email-masked]> wrote:

> Sorry for the resend. Original mail bounced from netdev.
> 
> On Thu, May 1, 2008 at 9:48 PM <[email-masked]> wrote:
> > Stephen,
> >
> >
> >  Stephen Hemminger [mailto:[email-masked]] wrote:
> >
> >  > Ramachandra K <[email-masked]> wrote:
> >
> >  >> +#define is_power_of2(value) (((value) & ((value - 1))) == 0)
> >  >> +#define ALIGN_DOWN(x, a)    ((x)&(~((a)-1)))
> >
> >  > In kernel.h already
> >
> >  Will fix this. Thanks.
> >
> >
> >  >> +extern u32 vnic_debug;
> >
> >  > Use msg level macros instead?

There is a ethtool mechanism to set message level for debug method, read other
network drivers and look at netif_msg_timer(x), netif_msg_probe(x), etc in
include/linux/netdevice.h

The goal here is to not have any special configuration for each different type
of hardware.  It is bad user design to have each hardware vendor choosing different
mechanism and values to enable debugging. You can argue that the existing infrastructure
is inadequate, in which case extend the infrastructure for all devices.