Subject: Re: [PATCH] fs_enet: Fix a memory leak in fs_enet_mdio_probe

From: Andrew Morton <[email-masked]>
Date: Fri, 2 May 2008 11:37:44 -0700

On Fri, 2 May 2008 13:31:18 -0500 Scott Wood <[email-masked]> wrote:

> There are more memory leaks in the !PPC_CPM_NEW_BINDING case, but that code
> will disappear soon along with arch/ppc.
> 
> Signed-off-by: Scott Wood <[email-masked]>
> ---
>  drivers/net/fs_enet/mii-fec.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
> index ba75efc..f0014cf 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -194,7 +194,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
>  
>  	ret = of_address_to_resource(ofdev->node, 0, &res);
>  	if (ret)
> -		return ret;
> +		goto out_res;
>  
>  	snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
>  
> @@ -236,6 +236,7 @@ out_free_irqs:
>  	kfree(new_bus->irq);
>  out_unmap_regs:
>  	iounmap(fec->fecp);
> +out_res:
>  out_fec:
>  	kfree(fec);
>  out_mii:

It would be nice to credit Daniel Marjamki <[email-masked]> in the
changelog, please.  Perhaps a mention of
http://bugzilla.kernel.org/show_bug.cgi?id=10591 also.