Subject: Re: [PATCH] sky2: fix simple define thinko

From: Stephen Hemminger <[email-masked]>
Date: Tue, 6 May 2008 16:18:43 -0700

On Tue, 06 May 2008 14:34:35 -0700
Jesse Brandeburg <[email-masked]> wrote:

> noticed while browsing code, apparent thinko.  compile tested only.
> 
> Signed-off-by: Jesse Brandeburg <[email-masked]>
> CC: Stephen Hemminger <[email-masked]>
> ---
> 
>  drivers/net/sky2.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
> index 7bb3ba9..c0a5eea 100644
> --- a/drivers/net/sky2.h
> +++ b/drivers/net/sky2.h
> @@ -1966,13 +1966,13 @@ struct sky2_status_le {
>  struct tx_ring_info {
>  	struct sk_buff	*skb;
>  	DECLARE_PCI_UNMAP_ADDR(mapaddr);
> -	DECLARE_PCI_UNMAP_ADDR(maplen);
> +	DECLARE_PCI_UNMAP_LEN(maplen);
>  };
>  
>  struct rx_ring_info {
>  	struct sk_buff	*skb;
>  	dma_addr_t	data_addr;
> -	DECLARE_PCI_UNMAP_ADDR(data_size);
> +	DECLARE_PCI_UNMAP_LEN(data_size);
>  	dma_addr_t	frag_addr[ETH_JUMBO_MTU >> PAGE_SHIFT];
>  };
>  
> 

Yes, this looks okay. We were safe up till now because ADDR > LEN