From: Ben Hutchings <bhutchings@solarflare•com>
To: Jeff Garzik <jgarzik@pobox•com>
Cc: netdev@vger•kernel.org, linux-net-drivers@solarflare•com
Subject: [PATCH 3/9] Removed bogus 'fall-thru' comments
Date: Wed, 7 May 2008 12:56:57 +0100 [thread overview]
Message-ID: <20080507115657.GO2217@solarflare.com> (raw)
In-Reply-To: <20080507114121.GL2217@solarflare.com>
Fall-through is expected outside a switch statement.
Signed-off-by: Ben Hutchings <bhutchings@solarflare•com>
---
drivers/net/sfc/falcon.c | 2 --
drivers/net/sfc/rx.c | 1 -
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index 46db549..9cac344 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -2468,14 +2468,12 @@ int falcon_probe_nic(struct efx_nic *efx)
fail5:
falcon_free_buffer(efx, &efx->irq_status);
fail4:
- /* fall-thru */
fail3:
if (nic_data->pci_dev2) {
pci_dev_put(nic_data->pci_dev2);
nic_data->pci_dev2 = NULL;
}
fail2:
- /* fall-thru */
fail1:
kfree(efx->nic_data);
return rc;
diff --git a/drivers/net/sfc/rx.c b/drivers/net/sfc/rx.c
index 551299b..9fd1984 100644
--- a/drivers/net/sfc/rx.c
+++ b/drivers/net/sfc/rx.c
@@ -736,7 +736,6 @@ void __efx_rx_packet(struct efx_channel *channel,
/* Update allocation strategy method */
channel->rx_alloc_level += RX_ALLOC_FACTOR_SKB;
- /* fall-thru */
done:
efx->net_dev->last_rx = jiffies;
}
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-05-07 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:41 [PATCH 0/9] sfc: various updates Ben Hutchings
2008-05-07 11:51 ` [PATCH 1/9] Add TSO support Ben Hutchings
2008-05-13 5:17 ` Jeff Garzik
2008-05-07 11:55 ` [PATCH 2/9] Add phy_flash_cfg module parameter and implementation Ben Hutchings
2008-05-07 11:56 ` Ben Hutchings [this message]
2008-05-07 20:30 ` [PATCH 3/9] Removed bogus 'fall-thru' comments Ilpo Järvinen
2008-05-09 12:12 ` Ben Hutchings
2008-05-07 11:57 ` [PATCH 4/9] Remove garbage from comment Ben Hutchings
2008-05-07 11:58 ` [PATCH 5/9] Remove kernel-doc comments for removed members of struct efx_nic Ben Hutchings
2008-05-07 11:58 ` [PATCH 6/9] Fix code formatting Ben Hutchings
2008-05-07 11:59 ` [PATCH 7/9] Remove unused macro EFX_XAUI_RETRAIN_MAX Ben Hutchings
2008-05-07 12:00 ` [PATCH 8/9] Increment rx_reset when reported as driver event Ben Hutchings
2008-05-07 12:36 ` [PATCH 9/9] sfc: Add self-test support Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507115657.GO2217@solarflare.com \
--to=bhutchings@solarflare$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox