From: Ben Dooks <ben-linux@fluff•org>
To: Jeff Garzik <jeff@garzik•org>
Cc: Ben Dooks <ben-linux@fluff•org>,
Linux Networking <netdev@vger•kernel.org>,
akpm@linux-foundation•org
Subject: DM9000: Update and fix driver debugging messages
Date: Thu, 8 May 2008 11:35:13 +0100 [thread overview]
Message-ID: <20080508103513.GD30439@fluff.org.uk> (raw)
In-Reply-To: <4820865F.70703@garzik.org>
From: Enrico Scholz <enrico.scholz@sigma-chemnitz•de>
There was a missing newline in a dev_dbg() message. Values read
from/written into PHY registers might be for interest too, so I added
new dbg messages there.
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz•de>
Signed-off-by: Ben Dooks <ben-linux@fluff•org>
---
drivers/net/dm9000.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 7bc16d2..e4af7a9 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -525,7 +525,7 @@ dm9000_probe(struct platform_device *pdev)
SET_NETDEV_DEV(ndev, &pdev->dev);
- dev_dbg(&pdev->dev, "dm9000_probe()");
+ dev_dbg(&pdev->dev, "dm9000_probe()\n");
/* setup board info structure */
db = (struct board_info *) ndev->priv;
@@ -1292,6 +1292,8 @@ dm9000_phy_read(struct net_device *dev, int phy_reg_unused, int reg)
spin_unlock_irqrestore(&db->lock,flags);
mutex_unlock(&db->addr_lock);
+
+ dm9000_dbg(db, 5, "phy_read[%02x] -> %04x\n", reg, ret);
return ret;
}
@@ -1305,6 +1307,7 @@ dm9000_phy_write(struct net_device *dev, int phyaddr_unused, int reg, int value)
unsigned long flags;
unsigned long reg_save;
+ dm9000_dbg(db, 5, "phy_write[%02x] = %04x\n", reg, value);
mutex_lock(&db->addr_lock);
spin_lock_irqsave(&db->lock,flags);
next prev parent reply other threads:[~2008-05-08 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 15:13 DM9000 patches Ben Dooks
2008-04-28 15:21 ` Jeff Garzik
2008-05-06 16:25 ` Jeff Garzik
2008-05-08 10:28 ` Ben Dooks
2008-05-08 10:33 ` DM9000: Add __devinit and __devexit attributes to probe and remove Ben Dooks
2008-05-13 5:18 ` Jeff Garzik
2008-05-08 10:35 ` Ben Dooks [this message]
2008-05-08 10:36 ` DM9000: Use delayed work to update MII PHY state Ben Dooks
2008-05-08 20:11 ` Andrew Morton
2008-05-08 20:18 ` Andrew Morton
2008-05-12 20:27 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508103513.GD30439@fluff.org.uk \
--to=ben-linux@fluff$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox