Subject: Re: [PATCH 1/3] net: handle errors from device_rename

From: Stephen Hemminger <[email-masked]>
Date: Thu, 15 May 2008 13:09:11 -0700

On Thu, 15 May 2008 16:41:40 +0800
Wang Chen <[email-masked]> wrote:

> Stephen Hemminger said the following on 2008-5-15 9:15:
> >  rollback:
> > -	device_rename(&dev->dev, dev->name);
> > +	err = device_rename(&dev->dev, dev->name);
> > +	if (err) {
> > +		memcpy(dev->name, oldname, IFNAMSIZ);
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> no need, dev->name didn't change in device_rename().
>  
> > +		return err;
> > +	}
> >  

dev->name has already been changed before the call to device_rename,
so it needs to be set back read the whole code context.