Subject: Re: [PATCH] [NET] uli526x: add support for netpoll

From: Anton Vorontsov <[email-masked]>
Date: Fri, 16 May 2008 15:13:49 +0400

On Thu, May 15, 2008 at 10:51:23PM +0200, Florian Fainelli wrote:
> Hello Anton,
> 
> Le Thursday 15 May 2008 17:12:55 Anton Vorontsov, vous avez écrit :
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +static void uli526x_poll(struct net_device *dev)
> > +{
> > +	/* ISR grabs the irqsave lock, so this should be safe */
> > +	uli526x_interrupt(dev->irq, dev);
> > +}
> > +#endif
> 
> You do not need to wrap this function into the ifdef, since setting the poll 
> callback is between ifdef. Otherwise patch looks good.

Nope, I need this #ifdef, otherwise gcc will warn about unused function
if netpoll is not selected.

Of course, I could do __maybe_unused, but #ifdef is what most (all?)
drivers are doing.

-- 
Anton Vorontsov
email: [email-masked]
irc://irc.freenode.net/bd2