Subject: Re: [PATCH 2/5] sky2: don't warn if page allocation fails

From: Stephen Hemminger <[email-masked]>
Date: Tue, 27 May 2008 11:47:23 -0700

On Thu, 22 May 2008 05:57:44 -0400
Jeff Garzik <[email-masked]> wrote:

> >  
> >  	for (i = 0; i < sky2->rx_nfrags; i++) {
> > -		struct page *page = alloc_page(GFP_ATOMIC);
> > +		struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
> >  
> >  		if (!page)
> >  			goto free_partial;
> 
> 
> IMO it's inappropriate to add these warnings to net drivers that 
> properly check all return values.
> 
> This approach is too maintenance intensive, and winds up fixing the same 
> problem over and over again -- a hint that the fix is in the wrong place.
> 
> 	Jeff
> 
> 

So the __GFP_NOWARN should go away and get replaced by GFP_WARN?