From: Thomas Graf <tgraf@suug•ch>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>
Cc: jeff@garzik•org, davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/3] [NET-NEXT]: Add DCB netlink interface definition
Date: Thu, 29 May 2008 00:37:28 +0200 [thread overview]
Message-ID: <20080528223728.GF20815@postel.suug.ch> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC32905281CD4@orsmsx414.amr.corp.intel.com>
* Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel•com> 2008-05-28 09:03
> 1. The netlink messages are generated via userspace when the connection
> is setup, plus they're generated from LLDP frames coming in off the
> wire. Those LLDP frames implement the DCBX protocol (Data Center
> Bridging Exchange), which is the negotiation protocol between a DCB
> device and its link partner. In most cases, it's a DCB-compliant
> switch, like a Cisco Nexus 5000. So the messages can come out of band
> depending on how the network gets configured, and if any events occur
> causing the bandwidth credits or priority mappings to change (think
> automated backups at night, wanting more bandwidth than during the day).
There isn't much difference really, instead of using the separate
interface you could simply add a new link attribute IFLA_DCB and issue
a RTM_SETLINK/RTM_GETLINK and send the same information in the same
format. However, I agree with you that a separate interface is better
in this case as dcb requests are not directly connected to other link
changes at all and the dcb message structure is pretty complex.
> 3. We wanted to use generic netlink, since that seems to be a more
> preferred method of netlink communication vs. rtnetlink. And I don't
> know anything about the info API, so I can't comment on why we didn't
> look at that for implementation. Can you suggest something for me to
> look at for the info API so I can see what that's all about?
A prominent user is the VLAN code in net/8021q/vlan_netlink.c
> Thanks Thomas. Other than that, is there anything in the netlink
> interface that you would suggest to change?
Looks good from here, I didn't read it all line by line though.
next prev parent reply other threads:[~2008-05-28 22:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 14:13 [PATCH] NET: DCB generic netlink interface PJ Waskiewicz
2008-05-27 14:13 ` [PATCH 1/3] [NET-NEXT]: Add DCB netlink interface definition PJ Waskiewicz
2008-05-28 9:41 ` Thomas Graf
2008-05-28 16:03 ` Waskiewicz Jr, Peter P
2008-05-28 22:37 ` Thomas Graf [this message]
2008-06-01 12:16 ` Waskiewicz Jr, Peter P
2008-06-05 13:17 ` Patrick McHardy
2008-06-09 22:11 ` Waskiewicz Jr, Peter P
2008-06-10 7:14 ` Patrick McHardy
2008-05-27 14:13 ` [PATCH 2/3] ixgbe: Add Data Center Bridging hardware initialization code PJ Waskiewicz
2008-05-27 14:13 ` [PATCH 3/3] ixgbe: Enable Data Center Bridging (DCB) support PJ Waskiewicz
2008-06-04 18:44 ` [PATCH] NET: DCB generic netlink interface David Miller
2008-06-05 6:23 ` Waskiewicz Jr, Peter P
2008-06-05 14:43 ` David Miller
2008-06-05 20:29 ` Thomas Graf
2008-06-10 19:55 ` Waskiewicz Jr, Peter P
2008-06-10 20:07 ` David Miller
2008-06-11 17:51 ` Thomas Graf
2008-06-11 17:50 ` Patrick McHardy
2008-06-11 21:28 ` Thomas Graf
2008-06-12 10:17 ` Patrick McHardy
2008-06-11 18:28 ` Waskiewicz Jr, Peter P
2008-06-11 21:26 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528223728.GF20815@postel.suug.ch \
--to=tgraf@suug$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox