From: Rusty Russell <rusty@rustcorp•com.au>
To: Mark McLoughlin <markmc@redhat•com>
Cc: netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
Herbert Xu <herbert@gondor•apana.org.au>
Subject: Re: [PATCH 3/3] virtio_net: Fix skb->csum_start computation
Date: Thu, 29 May 2008 17:31:16 +1000 [thread overview]
Message-ID: <200805291731.17131.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1211887247-31979-4-git-send-email-markmc@redhat.com>
On Tuesday 27 May 2008 21:20:47 Mark McLoughlin wrote:
> hdr->csum_start is the offset from the start of the ethernet
> header to the transport layer checksum field. skb->csum_start
> is the offset from skb->head.
>
> skb_partial_csum_set() assumes that skb->data points to the
> ethernet header - i.e. it computes skb->csum_start by adding
> the headroom to hdr->csum_start.
>
> Since eth_type_trans() skb_pull()s the ethernet header,
> skb_partial_csum_set() should be called before
> eth_type_trans().
As should the rx_bytes += skb->len. Thanks for this!
Applied (and 1/3, the typo patch).
I'll backport this to -stable, as well.
Thanks,
Rusty.
next prev parent reply other threads:[~2008-05-29 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 11:20 [PATCH 0/3] virtio_net GSO/partial csum fixes Mark McLoughlin
2008-05-27 11:20 ` [PATCH 1/3] virtio: Fix typo in virtio_net_hdr comments Mark McLoughlin
2008-05-27 11:20 ` [PATCH 2/3] virtio_net: Trivial coding style fix Mark McLoughlin
2008-05-27 11:20 ` [PATCH 3/3] virtio_net: Fix skb->csum_start computation Mark McLoughlin
2008-05-29 6:48 ` Herbert Xu
2008-05-29 7:31 ` Rusty Russell [this message]
2008-05-29 6:43 ` [PATCH 2/3] virtio_net: Trivial coding style fix Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805291731.17131.rusty@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=markmc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox