Subject: Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x_link

From: Ben Hutchings <[email-masked]>
Date: Sun, 1 Jun 2008 23:37:49 +0100

Andi Kleen wrote:
[...]
> > +/* Programs an image to DSP's flash via the SPI port*/
> > +static u8 bnx2x_sfx7101_flash_download(struct bnx2x *bp, u8 port,
> > +				     u8 ext_phy_addr,
> > +				     char data[], u32 size)
> 
> Hmm does the driver really need a flash updater as standard
> functionality? That could be a separate program.
[...]

It shouldn't need to do this.  The boot loader in the SFX7101 allows
flash update through MDIO if the appropriate pin is pulled low at
reset (see phy_flash_cfg option in the sfc driver).  Of course that
doesn't help if the board doesn't allow this to be controlled...

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.