Subject: Re: [ofa-general] Re: [PATCH v3 01/13] QLogic VNIC: Driver - netdev implementation

From: Stephen Hemminger <[email-masked]>
Date: Tue, 3 Jun 2008 10:51:24 -0700

On Tue, 3 Jun 2008 17:44:23 +0530
"Ramachandra K" <[email-masked]> wrote:

> On Thu, May 29, 2008 at 10:57 PM, Stephen Hemminger
> <[email-masked]> wrote:
> > On Thu, 29 May 2008 15:24:23 +0530
> > Ramachandra K <[email-masked]> wrote:
> 
> <snip>
> >
> >> +module_param(vnic_debug, uint, 0444);
> >> +MODULE_PARM_DESC(vnic_debug, "Enable debug tracing if > 0");
> >
> > maybe migrate this to ethtool msg_level?
> >
> 
> We investigated this and found that we cannot map all of our Infiniband
> level communication errors etc to the ethtool message levels. One option could
> be to add support for Ethtool message levels in addition to the vnic_debug
> controlled messages. The Ethtool support would make this driver conform
> to ethtool similar to other Ethernet drivers and the vnic_debug messages will
> help in debugging the Infiniband related errors.
> 
> Is ethtool support mandatory for a merge to 2.6.27 or can we consider
> it as a future
> enhancement while we first focus on moving this driver to use CONFIGFS ?
> 
> Regards,
> Ram

No problem, just a suggestion of how to make it easier to manage.