Subject: Re: [PATCH 1/12] BE NIC driver - Header files and initialization functions

From: Stephen Hemminger <[email-masked]>
Date: Wed, 4 Jun 2008 10:11:33 -0700

On Wed, 04 Jun 2008 01:25:14 -0700
"Subbu Seetharaman" <[email-masked]> wrote:

> Thanks for you comments Stephen.  
> 
> We did not make MSIx the default since most testing
> was done with INTx.  Since this version of the driver does not use multiple
> interrupt vectors, there is no performance advantage in using MSIx.
> If MSIx is still the preferred default, we can change it.

MSIx isn't shared but INTx is so there is at least some gain on big systems.

> 
> NAPI makes tasklet redundant in the RX completion processing; but
> we felt deffering TX completion processing to a tasklet is a better
> idea for 10Gb data rates than doing it in hard interrupt.

Okay, other drivers do TX completion processing  in NAPI handler.
It has the advantage of rate limiting the the TX completion in case
of really high transmit load.

> I will get back soon with other comments taken care of.
> 
> Subbu
>