From: Dave Dillow <dillowda@ornl•gov>
To: Roland Dreier <rdreier@cisco•com>
Cc: Amar Mudrankit <amar.mudrankit@qlogic•com>,
Greg KH <greg@kroah•com>,
general@lists•openfabrics.org, netdev@vger•kernel.org,
Stephen Hemminger <shemminger@vyatta•com>,
poornima.kamath@qlogic•com
Subject: Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for the driver
Date: Thu, 5 Jun 2008 01:40:35 -0400 [thread overview]
Message-ID: <20080605054035.GA8059@ornl.gov> (raw)
In-Reply-To: <aday75k1pzh.fsf@cisco.com>
On Wed, Jun 04, 2008 at 09:10:26PM -0700, Roland Dreier wrote:
> > Or so the theory goes. Unfortunately, you need all that information
> > before you can create the connection. The configfs guys have thought
> > about that, but not implemented yet:
> >
> > > [Committable Items]
> > > NOTE: Committable items are currently unimplemented.
>
> The netconsole code in-tree has a separate "enabled" attribute that
> serves the purpose of "committing" something. Seems good enough for SRP
> to use to me... the rename to commit idea seems cute but I don't see
> that it buys much beyond this.
But... But... I've got nothing.
I mentioned the enable attribute as a possible way to do it, though it is
counter to the configfs's documented preference. But it's there, it works
perfectly well, and the configfs guys have had over 2 years to implement
their alternate commit feature.
That said, given that SRP's been using sysfs since it went in, is there
a reason to move to configfs other than it's the new preferred way to do
it? Given the desire to not break ABI's -- and IIRC sysfs was declared to
be under that unbrella -- wouldn't we have to at least carry both
interfaces for a while, assuming we can even get rid of the sysfs one?
Carrying both adds a bit of a interesting twist -- targets added using
the sysfs add-target wouldn't show up under configfs. It may not be a
real problem, but it could be a bit of a surprise to an admin.
I'm not opposed to configfs, but the more I think about it, it doesn't
seem to bring much to the table for the SRP initiator other more code
and data structure size.
--
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office
next prev parent reply other threads:[~2008-06-05 5:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 9:53 [PATCH v3 00/13] QLogic VNIC Driver Ramachandra K
2008-05-29 9:54 ` [ofa-general] [PATCH v3 01/13] QLogic VNIC: Driver - netdev implementation Ramachandra K
2008-05-29 17:27 ` [ofa-general] " Stephen Hemminger
2008-06-03 12:14 ` Ramachandra K
2008-06-03 17:51 ` Stephen Hemminger
2008-05-29 9:54 ` [ofa-general] [PATCH v3 02/13] QLogic VNIC: Netpath - abstraction of connection to EVIC/VEx Ramachandra K
2008-05-29 9:55 ` [ofa-general] [PATCH v3 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx Ramachandra K
2008-05-29 9:55 ` [ofa-general] [PATCH v3 04/13] QLogic VNIC: Implementation of Control path of communication protocol Ramachandra K
2008-05-29 9:56 ` [ofa-general] [PATCH v3 05/13] QLogic VNIC: Implementation of Data " Ramachandra K
2008-05-29 9:56 ` [ofa-general] [PATCH v3 06/13] QLogic VNIC: IB core stack interaction Ramachandra K
2008-05-29 9:57 ` [ofa-general] [PATCH v3 07/13] QLogic VNIC: Handling configurable parameters of the driver Ramachandra K
2008-05-29 9:57 ` [ofa-general] [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for " Ramachandra K
2008-05-29 17:30 ` [ofa-general] " Stephen Hemminger
2008-05-29 17:48 ` Greg KH
2008-06-01 5:46 ` Roland Dreier
2008-06-03 12:24 ` [ofa-general] " Ramachandra K
2008-06-03 15:10 ` Roland Dreier
2008-06-03 18:25 ` Amar Mudrankit
2008-06-03 18:30 ` Greg KH
2008-06-03 18:45 ` David Dillow
2008-06-05 4:10 ` Roland Dreier
2008-06-05 5:40 ` Dave Dillow [this message]
2008-06-05 16:38 ` Roland Dreier
2008-06-05 17:01 ` Stephen Hemminger
2008-06-05 17:32 ` Patrick McHardy
2008-06-05 20:47 ` Roland Dreier
2008-06-05 22:54 ` Patrick McHardy
2008-06-05 17:54 ` David Dillow
2008-05-29 9:58 ` [ofa-general] [PATCH v3 09/13] QLogic VNIC: IB Multicast for Ethernet broadcast/multicast Ramachandra K
2008-05-29 9:58 ` [ofa-general] [PATCH v3 10/13] QLogic VNIC: Driver Statistics collection Ramachandra K
2008-05-29 9:59 ` [PATCH v3 11/13] QLogic VNIC: Driver utility file - implements various utility macros Ramachandra K
2008-05-29 9:59 ` [ofa-general] [PATCH v3 12/13] QLogic VNIC: Driver Kconfig and Makefile Ramachandra K
2008-05-29 10:00 ` [ofa-general] [PATCH v3 13/13] QLogic VNIC: Modifications to IB " Ramachandra K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605054035.GA8059@ornl.gov \
--to=dillowda@ornl$(echo .)gov \
--cc=amar.mudrankit@qlogic$(echo .)com \
--cc=general@lists$(echo .)openfabrics.org \
--cc=greg@kroah$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=poornima.kamath@qlogic$(echo .)com \
--cc=rdreier@cisco$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox