Subject: Re: [PATCH 2.6.25.3 5/5] atl1e: Atheros L1E Gigabit Ethernet driver

From: Stephen Hemminger <[email-masked]>
Date: Wed, 25 Jun 2008 22:46:11 -0700

On Thu, 26 Jun 2008 13:38:17 +0800
Jie Yang <[email-masked]> wrote:

> From: Jie Yang <[email-masked]>
> 
> Full patch for the Atheros L1E Gigabit Ethernet driver.
> Supportring AR8121, AR8113 and AR8114
> 
> Signed-off-by: Jie Yang <jie.yang @atheros.com>

> +#define AT_MII_LOCK(_adapter)                          \
> +       do {                                            \
> +               spin_lock(&(_adapter)->mdio_lock);      \
> +       } while (0)
> +
> +#define AT_MII_UNLOCK(_adapter)                                \
> +       do {                                            \
> +               spin_unlock(&(_adapter)->mdio_lock);    \
> +       } while (0)
> +
> +#define AT_MII_LOCK_IRQSAVE(_adapter, _flags)                          \
> +       do {                                                            \
> +               spin_lock_irqsave(&(_adapter)->mdio_lock, (_flags));    \
> +       } while (0)
> +
> +#define AT_MII_UNLOCK_IRQRESTORE(_adapter, _flags)                      \
> +       do {                                                             \
> +               spin_unlock_irqrestore(&(_adapter)->mdio_lock, (_flags));\
> +       } while (0)
> +

Please don't obfuscate (ie wrap) locking primitives. It makes it harder
for humans to evaluate the locking.