Subject: Re: Printing the driver name as part of the netdev watchdog message

From: Stephen Hemminger <[email-masked]>
Date: Sun, 6 Jul 2008 18:08:42 -0700

On Sun, 06 Jul 2008 15:53:18 -0700 (PDT)
David Miller <[email-masked]> wrote:

> From: Arjan van de Ven <[email-masked]>
> Date: Sun, 6 Jul 2008 13:08:01 -0700
> 
> > Does this patch look like the right approach for achieving the goal?
> 
> It's almost there.
> 
> You can issue an ethtool_ops->get_drvinfo() call, on devices which
> support ethtool, and fetch the driver info from there.
> 
> Your current method of obtaining this info can be used as the
> fallback when the ethtool op fails.

Maybe not. For consistency each call through ethtool_ops should
be holding rtnl mutex. And since dev_watchdog is a timer routine,
it is not safe to acquire a mutex there.