Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

From: Dave Jones <[email-masked]>
Date: Tue, 15 Jul 2008 19:40:37 -0400

On Tue, Jul 15, 2008 at 07:31:16PM -0400, Jeff Garzik wrote:
 > Sorry for not being specific.  I would have guessed the uglier
 > 
 > 	#ifdef CONFIG_8139TOO_PIO
 > 		static int use_io = 1;
 > 	#else
 > 		static int use_io;
 > 	#endif
 > 
 > since CONFIG_8139TOO_PIO doesn't convert to a 1 or 0 neatly in C AFAIK?

Hm, yeah. that only works in the PIO=1 case. When not set, it doesn't
end up in autoconf.h.  I'll go with the fugly ifdefs.

	Dave

-- 
http://www.codemonkey.org.uk