Subject: Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

From: David Miller <[email-masked]>
Date: Thu, 17 Jul 2008 14:37:53 -0700 (PDT)

From: Mariusz Kozlowski <[email-masked]>
Date: Thu, 17 Jul 2008 22:04:14 +0200

> Hello,
> 
> > +#define SPEED_0		   0xffff
> > +#define SPEED_10           10
> > +#define SPEED_100          100
> > +#define SPEED_100          100
> 
> Small thing - double define for SPEED_100.
> 
> > +#define SPEED_1000         1000

And these are all entirely superfluous, since they are already defined
in linux/ethtool.h